Caching pattern: Cache-Aside#495
Merged
Merged
Conversation
Owner
|
@christofferh the implementation looks good. Please update the documentation so we can proceed with the merge. |
chinnachalam
reviewed
Oct 3, 2016
| * Cache-Aside | ||
| */ | ||
| public void useCacheAsideStategy() { | ||
| System.out.println("# CachingPolicy.ASIDE"); |
There was a problem hiding this comment.
Is there any reason for not using logging framework like SLF4J or LOG4J Or Common logging?
Owner
There was a problem hiding this comment.
@chinnachalam you are right, using a logging framework would give some advantages such as ability to redirect output and filter output based on logging levels. But I think we should handle this issue on a more general level since there are multiple patterns not using a logging framework at the moment. Would you raise an issue about this matter, please?
Contributor
Author
Owner
|
Thank you @christofferh for this addition 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of #440, (+ minor style fixes)
I'll update documentation & UML once the solution has been reviewed and approved.