Skip to content

File renaming (index.md to README.md)#406

Merged
markusmo3 merged 1 commit into
iluwatar:masterfrom
slawiko:slawiko-patch-1
Mar 22, 2016
Merged

File renaming (index.md to README.md)#406
markusmo3 merged 1 commit into
iluwatar:masterfrom
slawiko:slawiko-patch-1

Conversation

@slawiko
Copy link
Copy Markdown
Contributor

@slawiko slawiko commented Mar 20, 2016

All index.md files renamed to README.md for more compatibility with github

@slawiko
Copy link
Copy Markdown
Contributor Author

slawiko commented Mar 20, 2016

I renamed these files with following python script:

import os

class RenameFileFromTo:
    def __init__(self, root, filename, new_filename):
        self.root = root
        self.filename = filename
        self.new_filename = new_filename

    def rename(self):
        for root, dirs, files in os.walk(self.root):
            for file in files:
                if file == self.filename:
                    os.rename(root + '/' + file, root + '/' + self.new_filename)

RenameFileFromTo(root_to_java-design-patterns, 'index.md', 'README.md').rename()

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 90.939% when pulling bd1b652 on slawiko:slawiko-patch-1 into 528d179 on iluwatar:master.

@npathai
Copy link
Copy Markdown
Contributor

npathai commented Mar 21, 2016

Ping @iluwatar . What do you think about this? Should we change the convention? I am not sure about this.

@markusmo3 Does this change affect our website?

@iluwatar
Copy link
Copy Markdown
Owner

@slawiko can you list the benefits of this? I can think of browsing the Github repository e.g. https://github.com/iluwatar/java-design-patterns/tree/master/abstract-factory and then Github would show the contents of the README.md automatically.

@markusmo3
Copy link
Copy Markdown
Contributor

Yes this would affect the website. But no huge changes would have to be made to make it work with README.md files.

It would improve readability on github(as seen here), so people that dont like our 'beautiful' website with its 'awesome' features could still browse on github

👍 from me

If @iluwatar and @npathai are okay with this i'll take over this issue

@iluwatar
Copy link
Copy Markdown
Owner

@markusmo3 it's ok for me

@slawiko
Copy link
Copy Markdown
Contributor Author

slawiko commented Mar 22, 2016

@iluwatar yes, you're right. It's only for improve readability on github. For example I do not browse your website in general, because for me github - most comfortable place for this.

@slawiko
Copy link
Copy Markdown
Contributor Author

slawiko commented Mar 22, 2016

@iluwatar @markusmo3 @npathai oh, I forgot one thing. We should change developer wiki: all mention of file index.md.

@markusmo3
Copy link
Copy Markdown
Contributor

Tested it locally and to my own surprising i dont have to change anything.
Jekyll should work with any *.md files as long as their respective YAML front matter is correct.

markusmo3 added a commit that referenced this pull request Mar 22, 2016
File renaming (index.md to README.md)
@markusmo3 markusmo3 merged commit aebd857 into iluwatar:master Mar 22, 2016
@npathai
Copy link
Copy Markdown
Contributor

npathai commented Mar 22, 2016

@markusmo3 Awesome. 👍
@slawiko Thanks for the PR.

@iluwatar
Copy link
Copy Markdown
Owner

@slawiko I see @markusmo3 already made the changes for developer wiki so this should be in order. Good work guys 👍

@slawiko
Copy link
Copy Markdown
Contributor Author

slawiko commented Mar 22, 2016

@iluwatar @markusmo3 @npathai Thank you, guys. This was my first submitted pull request. THANKS!

@slawiko slawiko deleted the slawiko-patch-1 branch March 22, 2016 17:48
@iluwatar iluwatar modified the milestone: 1.11.0 Apr 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants