Lock Pattern #71: Added mutex and semaphore modules to demonstrate locks by gwildor28 · Pull Request #397 · iluwatar/java-design-patterns

gwildor28 · 2016-03-07T19:53:22Z

Added two modules to demonstrate locks.

Mutex demonstrates a simple mutual exclusion lock. This is a binary lock which only allows one thread at a time to access the resource. See: Locks on Wikipedia

Semaphore demonstrates a semaphore for controlling access to a pool of resources. See Semaphores on Wikipedia

The main class of both programs is App.java.

I haven't created any documentation yet. Let me know if you want any changes or need some explanations of the code, etc.

Added two modules to demonstrate locks. Mutex demonstrates a simple mutual exclusion lock. Semaphore demonstrates a semaphore for controlling access to a pool of resources. The main class of both programs is App.java.

gwildor28 · 2016-03-18T20:06:53Z

Hi, just thought I'd check if anyone has had the opportunity to review this yet. i understand I haven't put any documentation in here yet but I just wanted to see if this is what you wanted to demonstrate the pattern

npathai · 2016-03-18T22:56:17Z

@gwildor28 It will be picked up for review soon.

gwildor28 · 2016-03-20T12:54:59Z

OK thanks

iluwatar · 2016-03-20T17:54:10Z

Review comments:

Mutex/App.java the pattern should be described here as well as the example implementation
Mutex example contains no tests
Mutex javadocs should be improved. They are not there just to satisfy the compiler. Please describe what each class and method does.
Mutex class diagram is missing
Mutex index.md is missing
Semaphore/App.java the pattern should be described here as well as the example implementation
Semaphore example contains no tests
Semaphore javadocs should be improved. They are not there just to satisfy the compiler. Please describe what each class and method does.
Semaphore class diagram is missing
Semaphore index.md is missing

iluwatar · 2016-03-20T18:10:08Z

+ */
+public class Jar {
+
+  private Lock lock;


private final Lock lock;

iluwatar · 2016-03-20T18:15:29Z

@gwildor28 you have my review comments. Please comment on this thread once you've addressed them so we'll do another review.

- Added descriptions - Added junit tests - Added javadoc - Added index.md - Added class diagrams

coveralls · 2016-03-24T18:33:29Z

Coverage decreased (-0.2%) to 90.692% when pulling 6e4b269 on gwildor28:master into 35d6a54 on iluwatar:master.

gwildor28 · 2016-03-26T16:53:35Z

I've addressed the items listed in the review comments in my commit 2 days ago

iluwatar · 2016-03-27T07:17:54Z

@gwildor28 there are merge conflicts. Can you pull the latest changes into your fork from the master?

Resubmit of updates

gwildor28 · 2016-03-30T08:11:40Z

I've merged your code into my branch, unfortunately Maven is complaining of problems in project dao. The first issue is a missing version tag in the pom.xml file, for junit-hierarchicalcontextrunner. Even after putting the tag in the file, Maven fails the tests for this project:

com.iluwatar.dao.AppTest - fails with a java.io.IOException related to the location of the database
com.iluwatar.dao.InMemoryCustomerDaoTest and com.iluwatar.dao.DbCustomerDaoTest - fail with java.lang.NoClassDefFoundError related to org/junit/internal/runners/rules/RuleFieldValidator
and de.bechte.junit.runners.validation.RuleValidator

Have you added any requirements for other software to be installed on this system?
The error in the pom.xml is the same problem that is failing the checks for this pull request

npathai · 2016-03-30T17:52:06Z

@gwildor28 I am the culprit for these errors. I will solve them first thing tomorrow. Sorry for the delay

gwildor28 · 2016-04-01T07:33:24Z

No problem.

gwildor28 · 2016-04-02T14:08:43Z

hi @npathai have you been able to look at this yet?

npathai · 2016-04-03T04:46:09Z

@gwildor28 Not yet. Give me a day, have been a bit busy.

gwildor28 · 2016-04-04T12:19:03Z

@npathai OK no problem

gwildor28 · 2016-04-06T16:07:19Z

Hi @npathai just thought to say I'm actually doing this lock pattern as part of a third year undergraduate degree module (open-source software) where I have to contribute to an existing open source project, The report is due on the 24th April and I'll get substantially more marks if I'm able to show a pull request of mine that got accepted. Do you think you'll realistically be able to sort out the errors within the next few days? Thanks

coveralls · 2016-04-13T18:45:45Z

Coverage decreased (-0.2%) to 90.83% when pulling ca8be7c on gwildor28:master into b72214d on iluwatar:master.

coveralls · 2016-04-14T17:06:02Z

Coverage increased (+0.07%) to 91.074% when pulling e821abd on gwildor28:master into b72214d on iluwatar:master.

gwildor28 · 2016-04-14T17:10:31Z

All seems to have passed the checks now, please review. Thanks

iluwatar · 2016-04-14T19:07:10Z

Looking quite good now @gwildor28 but still the tests are insufficient. Can you add unit test for Mutex.java and Semaphore.java?

coveralls · 2016-04-17T14:10:48Z

Coverage increased (+0.06%) to 91.065% when pulling a284329 on gwildor28:master into b72214d on iluwatar:master.

gwildor28 · 2016-04-17T19:34:48Z

Hi @iluwatar I've done the tests, please review. Thanks

iluwatar · 2016-04-18T18:16:03Z

Good work @gwildor28 Great to see you pull this through! 😄

gwildor28 · 2016-04-18T18:26:15Z

Thanks

iluwatar · 2020-07-28T16:42:41Z

@all-contributors please add @gwildor28 for code

allcontributors · 2020-07-28T16:42:48Z

@iluwatar

I've put up a pull request to add @gwildor28! 🎉

Added mutex and semaphore modules to demonstrate locks

3ed3bc1

Added two modules to demonstrate locks. Mutex demonstrates a simple mutual exclusion lock. Semaphore demonstrates a semaphore for controlling access to a pool of resources. The main class of both programs is App.java.

iluwatar added the status: under review label Mar 20, 2016

iluwatar reviewed Mar 20, 2016
View reviewed changes

Update according to review comments iluwatar#397

6e4b269

- Added descriptions - Added junit tests - Added javadoc - Added index.md - Added class diagrams

gwildor28 added 3 commits March 29, 2016 13:36

Merge remote-tracking branch 'refs/remotes/iluwatar/master'

474f265

Update According to Review Comments iluwatar#397

e2af78f

Resubmit of updates

Merge remote-tracking branch 'iluwatar/master'

187658c

gwildor28 added 3 commits April 13, 2016 18:51

Merge remote-tracking branch 'refs/remotes/iluwatar/master'

1fd15d5

pom update

3f9a756

pom update

ca8be7c

added relative paths to pom in mutex/semaphore

685d093

updated version to fix pom

e821abd

iluwatar self-assigned this Apr 16, 2016

JUnit tests

a284329

iluwatar merged commit 534fb67 into iluwatar:master Apr 18, 2016

allcontributors Bot mentioned this pull request Jul 28, 2020

docs: add gwildor28 as a contributor #1383

Merged

Uh oh!

Conversation

gwildor28 commented Mar 7, 2016

Uh oh!

gwildor28 commented Mar 18, 2016

Uh oh!

npathai commented Mar 18, 2016

Uh oh!

gwildor28 commented Mar 20, 2016

Uh oh!

iluwatar commented Mar 20, 2016

Uh oh!

iluwatar Mar 20, 2016

Choose a reason for hiding this comment

Uh oh!

iluwatar commented Mar 20, 2016

Uh oh!

coveralls commented Mar 24, 2016

Uh oh!

gwildor28 commented Mar 26, 2016

Uh oh!

iluwatar commented Mar 27, 2016

Uh oh!

gwildor28 commented Mar 30, 2016

Uh oh!

npathai commented Mar 30, 2016

Uh oh!

gwildor28 commented Apr 1, 2016

Uh oh!

gwildor28 commented Apr 2, 2016

Uh oh!

npathai commented Apr 3, 2016

Uh oh!

gwildor28 commented Apr 4, 2016

Uh oh!

gwildor28 commented Apr 6, 2016

Uh oh!

coveralls commented Apr 13, 2016

Uh oh!

coveralls commented Apr 14, 2016

Uh oh!

gwildor28 commented Apr 14, 2016

Uh oh!

iluwatar commented Apr 14, 2016

Uh oh!

coveralls commented Apr 17, 2016

Uh oh!

gwildor28 commented Apr 17, 2016

Uh oh!

iluwatar commented Apr 18, 2016

Uh oh!

gwildor28 commented Apr 18, 2016

Uh oh!

iluwatar commented Jul 28, 2020

Uh oh!

allcontributors Bot commented Jul 28, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants