docs: clarify Immutable Object pattern in Value Object README (fixes #3448)#3449
docs: clarify Immutable Object pattern in Value Object README (fixes #3448)#3449Senrian wants to merge 2 commits intoiluwatar:masterfrom
Conversation
PR SummaryThis PR updates documentation to explicitly treat the Immutable Object as the same pattern as Value Object, promoting the Immutable Object alias and clarifying intent. It also fixes a minor security issue in the sample code by switching to ProcessBuilder to avoid command injection. Two files are affected: the page-object App.java (execution reopening via process builder) and value-object README updates to reflect the pattern relationship and improved wording in the Intent section. Changes
autogenerated by presubmit.ai |
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
Files Processed (1)
- value-object/README.md (2 hunks)
Actionable Comments (0)
Skipped Comments (3)
-
value-object/README.md [22-22]
readability: "Clarify alias terminology"
-
value-object/README.md [26-26]
readability: "Clarify cross-reference with implementation"
-
value-object/README.md [28-30]
readability: "Improve Intent content clarity and Java/Lombok tie-in"
…to prevent command injection (CWE-78)
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- 7122b41: fix: replace Runtime.exec() string concatenation with ProcessBuilder to prevent command injection (CWE-78)
Files Processed (1)
- page-object/src/main/java/com/iluwatar/pageobject/App.java (1 hunk)
Actionable Comments (0)
Skipped Comments (1)
-
page-object/src/main/java/com/iluwatar/pageobject/App.java [80-81]
possible bug: "Windows command invocation clarity"
|
Fixes Issue #3448: Missing Pattern Immutable
The issue requests adding the Immutable Object pattern to the repository. This PR addresses it by:
Note: The Value Object pattern already implements the Immutable Object pattern (using Lombok
@Valueannotation). This PR makes that relationship explicit in the documentation.