Skip to content

#271 implements producer-consumer#276

Merged
iluwatar merged 1 commit intoiluwatar:masterfrom
hoswey:master
Oct 31, 2015
Merged

#271 implements producer-consumer#276
iluwatar merged 1 commit intoiluwatar:masterfrom
hoswey:master

Conversation

@hoswey
Copy link
Copy Markdown
Contributor

@hoswey hoswey commented Oct 28, 2015

implements the #271 ,pls help review

@iluwatar
Copy link
Copy Markdown
Owner

  • Put under review badge to the pull request
  • Does the example code implement the pattern correctly and follow good coding practices?
  • Does the example code have enough test coverage?
  • Is the example code commented well enough?
  • Is the example code following JavaDoc conventions?
  • Are the project coding conventions being followed?
  • Is the class diagram generated correctly?
  • Is the index.md implemented correctly so the pattern will show correctly on the web site?

I would put Producer-Consumer under concurrency patterns, but I do not count this as a mistake. Overall this pull request looks about as good as they get. No complaints from me, this is excellent work @hoswey !

iluwatar added a commit that referenced this pull request Oct 31, 2015
#271 implements producer-consumer
@iluwatar iluwatar merged commit 3dc9b2f into iluwatar:master Oct 31, 2015
pratigya0 pushed a commit to pratigya0/java-design-patterns that referenced this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants