Skip to content

Refactor monitor patterns example code#2560

Merged
iluwatar merged 3 commits into
iluwatar:masterfrom
bakazhou:master
Aug 20, 2023
Merged

Refactor monitor patterns example code#2560
iluwatar merged 3 commits into
iluwatar:masterfrom
bakazhou:master

Conversation

@bakazhou

@bakazhou bakazhou commented Aug 8, 2023

Copy link
Copy Markdown
Contributor

Refactor

  • Refactoring the code in monitor pattern that is not reasonable enough

Pull request description

  • Modify amount random value origin and bound
  • Add getBalance method in Bank class
  • Add test for new getBalance method
  • Some constants are extracted

It is my first pull request
Have a nice day😁

@sonatype-lift

sonatype-lift Bot commented Aug 8, 2023

Copy link
Copy Markdown

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

@sonarqubecloud

sonarqubecloud Bot commented Aug 8, 2023

Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

72.7% 72.7% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@iluwatar iluwatar merged commit 24090e4 into iluwatar:master Aug 20, 2023
@iluwatar

iluwatar commented Aug 20, 2023

Copy link
Copy Markdown
Owner

Looks good! Thank you for the contribution 🎉

@all-contributors please add @bakazhou for code

@allcontributors allcontributors Bot mentioned this pull request Aug 20, 2023
Merged
@allcontributors

allcontributors Bot commented Aug 20, 2023

Copy link
Copy Markdown
Contributor

@iluwatar

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I've put up a pull request to add @bakazhou! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iluwatar iluwatar iluwatar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bakazhou @iluwatar