Add data transfer hash pattern#1980
Closed
SpaceIshtar wants to merge 6 commits into
Closed
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
iluwatar
requested changes
Sep 11, 2022
Owner
iluwatar
left a comment
There was a problem hiding this comment.
Looks good in general. Just a couple of minor things to change
Comment on lines
+6
to
+10
| categories: Architectural | ||
| language: en | ||
| tags: | ||
| - Structural | ||
| - Decoupling |
Owner
There was a problem hiding this comment.
The pattern is listed under 'tier communications' category in the book 'J2EE design patterns'. I would put it under behavioral category with decoupling tag.
| <dependency> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-assembly-plugin</artifactId> | ||
| <version>3.0.0</version> |
Owner
There was a problem hiding this comment.
no need to specify the version - let the parent pom.xml decide it
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Owner
|
Closed due to inactivity |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request title
Pull request description