Skip to content

#111 Implementation of Step Builder pattern#194

Merged
iluwatar merged 2 commits intoiluwatar:masterfrom
dmitz:step-builder
Aug 10, 2015
Merged

#111 Implementation of Step Builder pattern#194
iluwatar merged 2 commits intoiluwatar:masterfrom
dmitz:step-builder

Conversation

@dmitz
Copy link
Copy Markdown
Contributor

@dmitz dmitz commented Aug 7, 2015

Added implementation of #111

@iluwatar
Copy link
Copy Markdown
Owner

iluwatar commented Aug 8, 2015

Hello @dmitz and thank you for the contribution.

I think the example code looks great and demonstrates the pattern well. Here's a couple of minor remarks:

  • When the code is run the console outputs This is a Paladin named a Amberjill armed Sword. I think this should be This is a paladin named Amberjill armed with a sword. The same applies to other lines of output.
  • We should credit the original author of the pattern in README.md section Credits.

Let me know once these changes have been applied.

@dmitz
Copy link
Copy Markdown
Contributor Author

dmitz commented Aug 10, 2015

@iluwatar It's done.

iluwatar added a commit that referenced this pull request Aug 10, 2015
#111 Implementation of Step Builder pattern
@iluwatar iluwatar merged commit a95bd31 into iluwatar:master Aug 10, 2015
@iluwatar
Copy link
Copy Markdown
Owner

Great job, thanks again.

pratigya0 pushed a commit to pratigya0/java-design-patterns that referenced this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants