#1001 fix intermittent test failure - changing Rect coordinates to double.#1008
Merged
Conversation
iluwatar
approved these changes
Oct 15, 2019
Owner
|
Thanks @Smirne for this fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1001 QuadTreeTest was showing intermittent failures.
The problem was due to the Rect data structure using int to store values (x, y, height, width).
Since the QuadTree divides its space in four, we need to either to change the Rect data structure or the divide algorithm.
I find the former more readable and clear.