Fix SOAP client failing to follow a scheme-less redirect Location#93
Closed
iliaal wants to merge 3 commits into
Closed
Fix SOAP client failing to follow a scheme-less redirect Location#93iliaal wants to merge 3 commits into
iliaal wants to merge 3 commits into
Conversation
6c3b40b to
5679aad
Compare
5679aad to
7c36a99
Compare
The HTTP redirect handler inherited scheme, host and port from the newly parsed Location URI itself instead of the previous request URI, so a scheme-less (relative or absolute-path) Location left the host NULL and the retry aborted with "Unable to parse URL". Read the inherited components and the path base from the request URI, restoring the behaviour the URI-parser refactor changed. Closes phpGH-22341
7c36a99 to
ef896b2
Compare
Owner
Author
|
Submitted upstream as php#22341. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a 3xx redirect with a scheme-less Location (relative or absolute-path), the redirect handler copied scheme/host/port from the freshly parsed Location URI itself rather than the previous request URI, leaving the host NULL so the retry aborted with "Unable to parse URL". Read the inherited components and the relative-path base from the request URI, restoring the pre-refactor behaviour.