[SimpleXML] Fix creating new attributes via attributes() dimension write - #264
Closed
iliaal wants to merge 1 commit into
Closed
[SimpleXML] Fix creating new attributes via attributes() dimension write#264iliaal wants to merge 1 commit into
iliaal wants to merge 1 commit into
Conversation
sxe_prop_dim_write() overwrote the element node with the first attribute node when resolving an SXE_ITER_ATTRLIST iterator, so xmlNewProp() targeted a non-element node and was skipped entirely when no attribute existed yet. Keep the element node in place and resolve only the attribute list start, so $x->attributes()["new"] = "v" creates the attribute like the symmetric $x["new"] path; property writes on the attributes() object share the fixed path while read/exists/unset handlers are unaffected by this defect.
iliaal
force-pushed
the
fix/sxml-attr-dim-84
branch
from
August 29, 2026 12:01
cbbe494 to
066a420
Compare
Owner
Author
|
Promoted to php#23500. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dimension writes like $x->attributes()["new"] = "v" did nothing for a not-yet-existing attribute, because sxe_prop_dim_write() replaced the element node with the first attribute node while resolving an SXE_ITER_ATTRLIST iterator, so xmlNewProp() hit a non-element node or never ran when the element had no attributes. sxe_prop_dim_write() now keeps the element node and resolves only the start of the attribute list, making dimension writes on attributes() behave like $x["new"] = "v". Property writes share this path and are fixed too; read, exists, and unset create nothing and are unaffected.