Closed
Conversation
package.json now supports file paths as arrays.
Kehrlann
reviewed
Nov 2, 2019
Collaborator
Kehrlann
left a comment
There was a problem hiding this comment.
This is not a small PR, it requires some work.
- As you've noticed fro the CI< It must be compatible with older versions of Node, unfortunately you can't expand arrays.
- This requires additional tests to define what's the expected behavior, especially when requiring an alias that has several potential paths.
| for (var alias in aliases) { | ||
| if (aliases[alias][0] !== '/') { | ||
| aliases[alias] = nodePath.join(base, aliases[alias]) | ||
| if (aliases[alias][0] !== '/') { |
Collaborator
There was a problem hiding this comment.
If aliases[alias] is an array, then you should do a different check on aliases[alias][0].
Collaborator
|
This PR has gone stale, I'm closing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Package.json now supports file paths which are arrays.