Skip to content

Delete irrelevant content#1093

Merged
lyj715824 merged 2 commits intoiflytek:mainfrom
lantianhemao:bugfix/lanmao-0325
Apr 15, 2026
Merged

Delete irrelevant content#1093
lyj715824 merged 2 commits intoiflytek:mainfrom
lantianhemao:bugfix/lanmao-0325

Conversation

@lantianhemao
Copy link
Copy Markdown
Contributor

Summary

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Refactoring

Related Issue

Changes

Testing

  • Existing tests pass
  • New tests added (if applicable)
  • Manual testing completed

Screenshots (if applicable)

Checklist

  • Code follows project coding standards
  • Self-review completed
  • Documentation updated (if needed)
  • Breaking changes documented

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates database migration scripts to change a descriptive string from '亚谋理想项目测试使用' to '项目测试使用' across several entries in V1.13__insert_config_data.sql and V1.14__insert_config_data2.sql. Additionally, it cleans up the vite.config.js file by removing numerous commented-out proxy target configurations. A review comment suggests that the hardcoded IP address in vite.config.js should be replaced with an environment variable for better flexibility and to avoid leaking internal network information.

// target: 'http://10.1.196.7:8080', // 旭东
// target: 'http://10.1.203.40:8080', // 彭颖
// target: 'http://10.1.200.151:8080', // 超睿
target: 'http://172.29.202.54:8080', // 联调服务器地址
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Hardcoding IP addresses in configuration files should be avoided. It makes the configuration inflexible for other developers and can leak internal network information.

It's recommended to use environment variables for this kind of configuration. Vite has built-in support for .env files.

You can refactor this to use loadEnv:

  1. In your .env or .env.development file, add:

    VITE_API_PROXY_TARGET=http://172.29.202.54:8080
    
  2. Then, update vite.config.js to load and use this variable:

    import { defineConfig, loadEnv } from 'vite';
    
    export default defineConfig(({ mode }) => {
      const env = loadEnv(mode, process.cwd(), '');
      return {
        // ... other config
        server: {
          proxy: {
            '/xingchen-api': {
              target: env.VITE_API_PROXY_TARGET,
              changeOrigin: true,
            },
            // ...
          },
        },
        // ...
      };
    });

This makes the proxy target easily configurable without changing the code.

@lyj715824 lyj715824 merged commit 4af09ed into iflytek:main Apr 15, 2026
25 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants