Conversation
Codecov Report
@@ Coverage Diff @@
## main #66 +/- ##
=========================================
Coverage 82.03% 82.03%
Complexity 377 377
=========================================
Files 37 37
Lines 1453 1453
Branches 148 148
=========================================
Hits 1192 1192
Misses 193 193
Partials 68 68
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
| "LOG_EVENT.timestamp_nanos": "timestamp_nanos", | ||
| "LOG_EVENT.spanId": "span_id", | ||
| "LOG_EVENT.traceId": "trace_id", | ||
| "LOG_EVENT.attributes": "attributes" |
There was a problem hiding this comment.
I think no extra handling is needed for attributes field which is a json string.
Currently map is stored in two columns, which is then combined to a Map<String, String> and then converted to a Json string, thus it needs to be specially handled.
attributes field is already stored as a json string (with 1 level nesting).
This comment has been minimized.
This comment has been minimized.
| viewName = logEventView | ||
| bytesFields = ["span_id", "trace_id"] | ||
| fieldMap = { | ||
| "LOG_EVENT.timestamp_nanos": "timestamp_nanos", |
There was a problem hiding this comment.
Heads up on this line if the attr key changes
This comment has been minimized.
This comment has been minimized.
|
@rish691 Pl. add description and associated embedded log events issue ticket. |
aaron-steinfeld
left a comment
There was a problem hiding this comment.
lgtm pending description
Unit Test Results 22 files 22 suites 6s ⏱️ Results for commit 12ba0b8. |
Add LogEventView
hypertrace/hypertrace#224