Conversation
Codecov Report
@@ Coverage Diff @@
## main #131 +/- ##
=========================================
Coverage 81.25% 81.25%
Complexity 574 574
=========================================
Files 53 53
Lines 2235 2235
Branches 236 236
=========================================
Hits 1816 1816
Misses 325 325
Partials 94 94
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| Arguments.arguments( | ||
| buildQueryFromJsonFile("query4.json"), | ||
| 10, | ||
| "{\"internal.span.format\":\"jaeger\",\"http.status_code\":\"200\",\"component\":\"net/http\",\"span.kind\":\"server\",\"sampler.type\":\"const\",\"sampler.param\":\"1\",\"http.url\":\"/dispatch?customer=392&nonse=0.2664909002836733\",\"servicename\":\"frontend\",\"http.method\":\"GET\"}")); |
There was a problem hiding this comment.
Can you also put that in json file as query4-expected-response.json? (its not redable)
There was a problem hiding this comment.
It is coming in this format only. It is a string.
There was a problem hiding this comment.
created a new test for this case.
This comment has been minimized.
This comment has been minimized.
| List<Row> rows = list.get(0).getRowList(); | ||
| assertEquals(10, rows.size()); | ||
| assertEquals( | ||
| "\"http.status_code\":\"200\"", rows.get(0).getColumn(0).getString().split(",")[1]); |
There was a problem hiding this comment.
Are all the rows are having the same values? Would this always be true that the first-row first column will have this value?
There was a problem hiding this comment.
Are all the rows are having the same values?
No
Would this always be true that the first-row first column will have this value?
Should be as we are generating same load ?
| LOG.info("Not contains key query"); | ||
| Iterator<ResultSetChunk> itr = | ||
| queryServiceClient.executeQuery( | ||
| buildQueryFromJsonFile("query4.json"), TENANT_ID_MAP, 10000); |
There was a problem hiding this comment.
is there a 1-1 mapping between the test method and query file, if yes then maybe you can name the query file after the method name?
Ref issue : #130