Conversation
Codecov Report
@@ Coverage Diff @@
## main #123 +/- ##
============================================
- Coverage 81.21% 81.11% -0.11%
+ Complexity 573 569 -4
============================================
Files 53 53
Lines 2204 2192 -12
Branches 234 235 +1
============================================
- Hits 1790 1778 -12
Misses 319 319
Partials 95 95
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@rish691 As part of this PR, can you put the constraints on log4j related library coming from a third party to use the latest |
|
|
||
| @Override | ||
| public void onResponse(Call call, Response response) throws IOException { | ||
| public void onResponse(@NonNull Call call, @NonNull Response response) { |
There was a problem hiding this comment.
why do we need explicitly @NonNull?
There was a problem hiding this comment.
IDE suggestion, it says Not annotated parameter overrides @NotNull parameter , basically this param is marked not null in the parent
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| ValueCase valueCase = expression.getValueCase(); | ||
| switch (valueCase) { |
There was a problem hiding this comment.
nit
| ValueCase valueCase = expression.getValueCase(); | |
| switch (valueCase) { | |
| switch (expression.getValueCase()) { |
From #119