Skip to content

chore: enable executors otel module by default #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thugrock7 merged 4 commits into from
Sep 3, 2025
Merged

chore: enable executors otel module by default #431

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f7ddff2
revert 2dff5262c6dc88d028ab276d3f6e8f3b924f3a09
thugrock7 Sep 2, 2025
5bcc655
enable executors module
thugrock7 Sep 2, 2025
1e12563
upload jar as artifact
thugrock7 Sep 2, 2025
9c1a3be
null the context attrs after usage
thugrock7 Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
null the context attrs after usage
  • Loading branch information
@thugrock7
thugrock7 committed Sep 2, 2025
commit 9c1a3beac7a3298bb558f1b6a4d137cd888de7f1
10 changes: 10 additions & 0 deletions ...aagent/instrumentation/hypertrace/netty/v4_1/client/HttpClientResponseTracingHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,16 @@ public void channelRead(ChannelHandlerContext ctx, Object msg) {
span.setStatus(code >= 100 && code < 400 ? StatusCode.UNSET : StatusCode.ERROR);
}
if (msg instanceof LastHttpContent) {
// When we end the span, we should set the client context and client parent attr to null.
// so that for the next request a new context is made and stored in channel.
ctx.channel()
.attr(io.opentelemetry.instrumentation.netty.v4_1.internal.AttributeKeys.CLIENT_CONTEXT)
.set(null);
ctx.channel()
.attr(
io.opentelemetry.instrumentation.netty.v4_1.internal.AttributeKeys
.CLIENT_PARENT_CONTEXT)
.set(null);
span.end();
}
}
Expand Down
Loading