Default to zipkin exporter#305
Merged
Merged
Conversation
Add abstract client tests (hypertrace#246)
Pull hypertrace main
publishing filter-api (hypertrace#252)
pull main
pull main
davexroth
reviewed
Apr 13, 2021
| Assertions.assertEquals( | ||
| ResourceAttributes.TELEMETRY_SDK_NAME.getKey(), | ||
| traces.get(0).getResourceSpans(0).getResource().getAttributes(12).getKey()); | ||
| traces.get(0).getResourceSpans(0).getResource().getAttributes(0).getKey()); |
Contributor
There was a problem hiding this comment.
Rather than revert these tests, can we configure the tests to run with otlp?
Contributor
Author
There was a problem hiding this comment.
Sure, we can use OTLP in config while running these tests.
davexroth
approved these changes
Apr 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert defaulting to OTLP exporter.