fix: resolve the issue of running hypertrace-alert-engine with postgres#276
fix: resolve the issue of running hypertrace-alert-engine with postgres#276kotharironak merged 7 commits intomainfrom
Conversation
| condition: service_started | ||
|
|
||
| hypertrace-alert-engine: | ||
| image: hypertrace/hypertrace-alert-engine:1.0.7 |
There was a problem hiding this comment.
Once, we have fixed for latest version, we will remove the version tag.
There was a problem hiding this comment.
Fixed! Could you check once and update here.
|
@rish691 @JBAhire This changes make sure that our instruction of starting all services remains same - https://github.com/hypertrace/hypertrace#run-with-docker-compose |
| container_name: hypertrace-alert-engine | ||
| # comment below two lines if you want to run alert-engine after modifying appropriate | ||
| # alert-rules.json and notification-rules.json files | ||
| entrypoint: [ "/bin/sh" ] |
| # service_started, not service_healthy as pinot and deps can take longer than 60s to start | ||
| condition: service_started | ||
|
|
||
| hypertrace-alert-engine: |
There was a problem hiding this comment.
@kotharironak , I see what you have done here. Ideally the way we had 2 different files earlier makes more sense considering I don't want alerting when I am trying it out for first time anyways because I am just trying out platform.
If directory or command is the problem, we can have duplicate files but let's have it in 2 steps. First step will be quick-start with Hypertrace and then try out alerting with Hypertrace. It will be cleaner way because you will need to stop and start the whole stack again in your case anyways but then there's additional thing to do that is comment these lines etc.
cc: @rish691
There was a problem hiding this comment.
@JBAhire In that case, we need a copy of the same files in postgres folder. I can do that as well. I will copy alerting files in postgres folder then.
There was a problem hiding this comment.
As discussed offline with @JBAhire, let's keep the default + postgres folder in sync. And, we will go with one simple command.
docker-compose -f <default file> -f <alerting file>
| # alert-rules.json and notification-rules.json files | ||
| entrypoint: [ "/bin/sh" ] | ||
| command: [ "-c", | ||
| "echo Pl. comment out entrypoint and command to run alert engine |
There was a problem hiding this comment.
In case we agree to go with this one, don't use abbreviations here.
|
Verified using command as below, |
Description
docker-compose -f <> upcommandTesting
Checklist:
Documentation