Skip to content

refactor: removed container name from docker-compose to avoid conflict#243

Merged
JBAhire merged 2 commits intomainfrom
update-docker-compose
May 13, 2021
Merged

refactor: removed container name from docker-compose to avoid conflict#243
JBAhire merged 2 commits intomainfrom
update-docker-compose

Conversation

@JBAhire
Copy link
Copy Markdown
Member

@JBAhire JBAhire commented May 13, 2021 •
edited
Loading

Description

  • Removed default container-name from docker-compose file to avoid conflicts by container name with deployments like this:
    image (1)

Testing

  • Tested locally and also runs in e2e test.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

cc: @jcchavezs

@JBAhire JBAhire marked this pull request as ready for review May 13, 2021 10:06
@JBAhire JBAhire requested review from findingrish and jcchavezs May 13, 2021 10:06
@JBAhire JBAhire merged commit d7e737a into main May 13, 2021
@JBAhire JBAhire deleted the update-docker-compose branch May 13, 2021 10:48
@jcchavezs jcchavezs mentioned this pull request Aug 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcchavezs jcchavezs jcchavezs approved these changes

@findingrish findingrish Awaiting requested review from findingrish

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JBAhire @jcchavezs