Repository navigation
chore: upgrade to 17 - BREAKING CHANGE - #978
Merged
Merged
Conversation
Test Results53 tests 53 ✅ 16s ⏱️ Results for commit 33bcfdd. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #978 +/- ##
=======================================
Coverage 99.67% 99.67%
=======================================
Files 49 49
Lines 607 607
Branches 38 35 -3
=======================================
Hits 605 605
Misses 2 2 ☔ View full report in Codecov by Sentry. |
aaron-steinfeld
left a comment
Contributor
There was a problem hiding this comment.
Please mark the change as breaking. should be a major version bump
Contributor
|
Also as long as you're in here, do you mind updating the GHA config to bump some of the deprecated action versions: |
BREAKING CHANGE: Requires min Angular version 17
Co-authored-by: Aaron Steinfeld <45047841+aaron-steinfeld@users.noreply.github.com>
aaron-steinfeld
approved these changes
Apr 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgrade Angular to v17