This repository was archived by the owner on Jun 26, 2024. It is now read-only.
fix: omit time range on time agnostic entity query#89
Merged
aaron-steinfeld merged 1 commit intomainfrom Apr 23, 2021
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## main #89 +/- ##
============================================
+ Coverage 77.02% 77.07% +0.04%
- Complexity 1094 1096 +2
============================================
Files 106 106
Lines 4980 4981 +1
Branches 424 425 +1
============================================
+ Hits 3836 3839 +3
+ Misses 955 954 -1
+ Partials 189 188 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
tim-mwangi
approved these changes
Apr 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Time range was being applied on entity service queries even if it was requested as time agnostic
Testing
Added UTs
Checklist: