fix: use requested alias for result metadata#150
Merged
aaron-steinfeld merged 5 commits intomainfrom Jan 4, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #150 +/- ##
============================================
+ Coverage 62.26% 62.47% +0.21%
- Complexity 332 336 +4
============================================
Files 43 43
Lines 3254 3251 -3
Branches 380 380
============================================
+ Hits 2026 2031 +5
+ Misses 1045 1037 -8
Partials 183 183
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
|
Since this is a small PR, can we also fix |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
sarthak77
approved these changes
Dec 30, 2021
Contributor
Author
|
@hypertrace/query-layer-owners please review. |
kotharironak
approved these changes
Jan 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In prior iterations EQS disregarded the alias being provided when naming its response columns, which is kind of the whole point of an alias :). This change fixes that.
Testing
Added UT, Verified still working E2E.
Checklist: