Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #111 +/- ##
============================================
+ Coverage 59.64% 59.74% +0.09%
Complexity 296 296
============================================
Files 39 39
Lines 2964 2971 +7
Branches 368 368
============================================
+ Hits 1768 1775 +7
Misses 1025 1025
Partials 171 171
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
findingrish
approved these changes
Jul 9, 2021
suddendust
pushed a commit
to suddendust/entity-service
that referenced
this pull request
Sep 5, 2025
…ypertrace#111) * feat: add support for creatTime and lastUpdateTime * fetch the createTime if document exists * add support of modifying last updated time for subdoc path * removed commented code * addressed comments * Fixed the integration test * addressed comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently we have no metrics for the various cache used in EdsCacheClient.
Adding metrics for them.
Testing
The metrics are directly exported to Prometheus. Hence, there are no tests performed for this. Since the tests for the meter registry are already is place in the service-framework.
Checklist: