Skip to content

Renaming Tags with Labels#50

Merged
saxenakshitiz merged 4 commits intomainfrom
ENG-11219
Aug 26, 2021
Merged

Renaming Tags with Labels#50
saxenakshitiz merged 4 commits intomainfrom
ENG-11219

Conversation

@kamaleshnneerasa
Copy link
Copy Markdown
Contributor

@kamaleshnneerasa kamaleshnneerasa commented Aug 26, 2021

Description

Please include a summary of the change, motivation and context.
Renaming all the code that uses Tags with Labels

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 26, 2021

Codecov Report

Merging #50 (18a888b) into main (37373f4) will increase coverage by 0.05%.
The diff coverage is 96.96%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #50      +/-   ##
============================================
+ Coverage     91.98%   92.04%   +0.05%     
  Complexity      137      137              
============================================
  Files            16       16              
  Lines           549      553       +4     
  Branches         24       24              
============================================
+ Hits            505      509       +4     
  Misses           37       37              
  Partials          7        7              
Flag Coverage Δ
integration 92.04% <96.96%> (+0.05%) ⬆️
unit 90.72% <96.96%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/label/config/service/LabelConfigServiceImpl.java 96.34% <96.34%> (ø)
...l/config/service/ConfigServiceCoordinatorImpl.java 95.74% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37373f4...18a888b. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@saxenakshitiz saxenakshitiz merged commit e84f734 into main Aug 26, 2021
@saxenakshitiz saxenakshitiz deleted the ENG-11219 branch August 26, 2021 17:34
@github-actions
Copy link
Copy Markdown

Unit Test Results

11 files  ±0  11 suites  ±0   8s ⏱️ ±0s
42 tests ±0  42 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e84f734. ± Comparison against base commit 37373f4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants