Skip to content

chore: creating lazy errors#97

Merged
avinashkolluru merged 1 commit intomainfrom
lazy_single_errors
Jul 22, 2021
Merged

chore: creating lazy errors#97
avinashkolluru merged 1 commit intomainfrom
lazy_single_errors

Conversation

@avinashkolluru
Copy link
Copy Markdown
Contributor

Description

Excessive error construction was eating up CPU cycles - changed to lazy construction, and added a throttled log message

@avinashkolluru avinashkolluru requested review from a team and aaron-steinfeld July 22, 2021 14:08
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 22, 2021

Codecov Report

Merging #97 (1fe41cd) into main (d547b6b) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #97      +/-   ##
============================================
+ Coverage     80.76%   80.81%   +0.05%     
- Complexity      225      227       +2     
============================================
  Files            28       28              
  Lines           759      761       +2     
  Branches         56       56              
============================================
+ Hits            613      615       +2     
  Misses           99       99              
  Partials         47       47              
Flag Coverage Δ
integration 80.81% <100.00%> (+0.05%) ⬆️
unit 68.04% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/cachingclient/DefaultCachingAttributeClient.java 95.83% <100.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d547b6b...1fe41cd. Read the comment docs.

@github-actions

This comment has been minimized.

@avinashkolluru avinashkolluru merged commit 5931c59 into main Jul 22, 2021
@avinashkolluru avinashkolluru deleted the lazy_single_errors branch July 22, 2021 14:29
@github-actions
Copy link
Copy Markdown
Contributor

Unit Test Results

21 files  ±0  21 suites  ±0   11s ⏱️ ±0s
77 tests ±0  77 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 5931c59. ± Comparison against base commit d547b6b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants