Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #93 +/- ##
============================================
+ Coverage 80.71% 80.76% +0.04%
- Complexity 222 225 +3
============================================
Files 27 28 +1
Lines 752 759 +7
Branches 56 56
============================================
+ Hits 607 613 +6
- Misses 98 99 +1
Partials 47 47
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
tim-mwangi
approved these changes
Apr 20, 2021
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This new operator, CONCAT_OR_NULL adds a variant of concat behavior where concat'ing null with another value returns null. Our current CONCAT operator returns the value in this case (would rather flip this behavior and have the null propagate by default, but that's breaking). Similar behavior variants are present in SQL databases such as https://docs.microsoft.com/en-us/sql/t-sql/statements/set-concat-null-yields-null-transact-sql?view=sql-server-ver15#:~:text=When%20SET%20CONCAT_NULL_YIELDS_NULL%20is%20ON,treated%20as%20an%20empty%20string).
Testing
Added UT, verified E2E
Checklist: