Skip to content

chore: Upgrade gradle version#103

Merged
findingrish merged 2 commits intomainfrom
gradle-upgrade
Aug 27, 2021
Merged

chore: Upgrade gradle version#103
findingrish merged 2 commits intomainfrom
gradle-upgrade

Conversation

@findingrish
Copy link
Copy Markdown

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@findingrish findingrish requested a review from a team August 27, 2021 09:25
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 27, 2021

Codecov Report

Merging #103 (57cf6d0) into main (00abb99) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #103   +/-   ##
=========================================
  Coverage     81.28%   81.28%           
  Complexity      232      232           
=========================================
  Files            28       28           
  Lines           791      791           
  Branches         57       57           
=========================================
  Hits            643      643           
  Misses          100      100           
  Partials         48       48           
Flag Coverage Δ
integration 81.28% <ø> (ø)
unit 68.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00abb99...57cf6d0. Read the comment docs.

@github-actions

This comment has been minimized.

tim-mwangi
tim-mwangi previously approved these changes Aug 27, 2021
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-6.5.1-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-7.1.1-all.zip
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Came up on other reviews, but just since this one's approved just reposting: let's make sure we're using gradle 7.2 and fixing snyk before merging all these.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged entity-service with gradle 7.1.1, I'll fix that

@findingrish
Copy link
Copy Markdown
Author

@aaron-steinfeld I am not able to find this repository in snyk ui

@aaron-steinfeld
Copy link
Copy Markdown
Contributor

aaron-steinfeld commented Aug 27, 2021

@aaron-steinfeld I am not able to find this repository in snyk ui

it's in there, look towards the bottom (second from bottom for me on the project list)

@github-actions

This comment has been minimized.

@findingrish findingrish merged commit a44cc53 into main Aug 27, 2021
@findingrish findingrish deleted the gradle-upgrade branch August 27, 2021 17:04
@github-actions
Copy link
Copy Markdown
Contributor

Unit Test Results

21 files  ±0  21 suites  ±0   8s ⏱️ -4s
77 tests ±0  77 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a44cc53. ± Comparison against base commit 00abb99.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants