fix(ci): restore Bun workflow startup - #736
Conversation
|
Warning Review limit reachedNext included review available in 31 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Pull Request Overview
This PR restores the Bun CI workflow by reverting the setup-bun action to version 2.0.2 (via a secure full-SHA pin), which maintains compatibility with the Node 20 runtime. It also pins the Bun runtime to version 1.3.14 to ensure consistency. Codacy analysis confirms the changes are up to standards with no new quality issues.
Test suggestions
- Verify CI workflow successfully instantiates and starts jobs without producing a 'startup_failure' error
- Verify that the 'Run native Bun-ESM tests' step executes successfully using the pinned Bun version
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
There was a problem hiding this comment.
Pull Request Overview
This PR restores the Bun CI workflow by replacing the setup-bun action with a manual installation and verification script for Bun 1.3.14. This bypasses the Node 24 requirement in newer versions of the action.
While functional, the implementation diverges from the PR description, which stated a 'full-SHA action pin' would be retained; instead, the action was removed entirely. Codacy analysis indicates the changes are up to standards.
About this PR
- The implementation significantly diverges from the PR description. The documentation suggests pinning the setup-bun action to a specific version, but the code replaces the action entirely with a manual shell script.
Test suggestions
- Verify Bun archive integrity via sha256sum
- Confirm Bun version 1.3.14 is correctly installed and executable in PATH
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
| node-version: "20" | ||
| - name: Set up Bun | ||
| uses: oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 # v2 | ||
| # The repository's selected-action path rejects setup-bun before job |
There was a problem hiding this comment.
🟡 MEDIUM RISK
The implementation removes the oven-sh/setup-bun action entirely. This contradicts the PR description which states the PR would 'retain a full-SHA action pin' on a compatible release.
| archive="$RUNNER_TEMP/bun-linux-x64.zip" | ||
| install_dir="$RUNNER_TEMP/bun-runtime" | ||
| curl --fail --location --retry 3 \ | ||
| --output "$archive" \ | ||
| "https://github.com/oven-sh/bun/releases/download/bun-v${BUN_VERSION}/bun-linux-x64.zip" |
There was a problem hiding this comment.
⚪ LOW RISK
Suggestion: To keep CI logs clean and the workspace tidy, use the -sS flags with curl to silence the progress bar and store the temporary archive in $RUNNER_TEMP instead of the repository root.
|
Summary
startup_failurebefore any job was instantiatedEvidence
startup_failureonly for.github/workflows/ci.ymlruns.using: node24This PR must not merge until its own
CIworkflow instantiates jobs and passes.