Fix: Cancelling fork dialog with ESC no longer clears input#921
Open
Nithishvb wants to merge 1 commit intohumanlayer:mainfrom
Open
Fix: Cancelling fork dialog with ESC no longer clears input#921Nithishvb wants to merge 1 commit intohumanlayer:mainfrom
Nithishvb wants to merge 1 commit intohumanlayer:mainfrom
Conversation
|
|
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 58a0182 in 52 seconds. Click for details.
- Reviewed
12lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. humanlayer-wui/src/components/internal/SessionDetail/components/ActiveSession.tsx:238
- Draft comment:
Good fix to stop clearing input on fork cancel. However, since responseEditor is no longer referenced in handleForkCancel, please remove it from the dependency array. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_Qhbtf2Rx4MfIR7B4
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem(s) was I solving?
What user-facing changes did I ship?
How I implemented it
How to verify it
make check testpassesDescription for the changelog
Closes: #893
Cancelling the fork dialog using the ESC key was unintentionally clearing the input field, causing users to lose any text they had already typed. This PR fixes that behavior by ensuring the input state is preserved unless the user explicitly submits or clears it.
A picture of a cute animal (not mandatory but encouraged)
Important
Fixes issue in
ActiveSession.tsxwhere pressing ESC in fork dialog cleared input field, preserving input state unless explicitly cleared.ActiveSession.tsx.responseEditor?.commands.setContent('')fromhandleForkCancelinActiveSession.tsx.This description was created by
for 58a0182. You can customize this summary. It will automatically update as commits are pushed.