fix(wui): move Google Fonts @import to top#917
Open
digi4care wants to merge 1 commit intohumanlayer:mainfrom
Open
fix(wui): move Google Fonts @import to top#917digi4care wants to merge 1 commit intohumanlayer:mainfrom
digi4care wants to merge 1 commit intohumanlayer:mainfrom
Conversation
|
Chris Engelhard seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to ded523b in 40 seconds. Click for details.
- Reviewed
16lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. humanlayer-wui/src/App.css:1
- Draft comment:
Good move: the Google Fonts @import is now at the very top, satisfying PostCSS's import order requirement. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, as it simply acknowledges a change that satisfies a requirement without suggesting any action or improvement. It doesn't provide any actionable feedback or raise any concerns.
2. humanlayer-wui/src/App.css:7
- Draft comment:
Duplicate Google Fonts @import was removed—this cleanup avoids redundancy. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, as it simply states that a duplicate import was removed. It doesn't provide any actionable feedback or suggestions for improvement.
Workflow ID: wflow_KqXgH17gQGUJYDYb
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes PostCSS warning about @import order by moving the Google Fonts import to the very top of humanlayer-wui/src/App.css.
Repro:
After:
Important
Moves Google Fonts
@importto the top ofApp.cssto fix PostCSS import order warning.@importto the top ofApp.cssto fix PostCSS warning about import order.@importprecedes Tailwind import expansion, removing the warning.This description was created by
for ded523b. You can customize this summary. It will automatically update as commits are pushed.