Fix: claude init now copies required hack scripts#903
Open
vruss wants to merge 1 commit intohumanlayer:mainfrom
Open
Fix: claude init now copies required hack scripts#903vruss wants to merge 1 commit intohumanlayer:mainfrom
vruss wants to merge 1 commit intohumanlayer:mainfrom
Conversation
|
|
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to a60bbb7 in 40 seconds. Click for details.
- Reviewed
83lines of code in1files - Skipped
0files when reviewing. - Skipped posting
5draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. hlyr/src/commands/claude/init.ts:111
- Draft comment:
Including 'scripts' in the --all flag selection ensures hack scripts are always copied. This satisfies the issue requirement. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. hlyr/src/commands/claude/init.ts:133
- Draft comment:
The interactive selection now includes 'scripts' with an appropriate hint and initial value. This is good for user clarity. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. hlyr/src/commands/claude/init.ts:334
- Draft comment:
The branch for the 'scripts' category properly resolves the source hack directory and copies required scripts, including setting executable permissions. This correctly addresses the missing file issue. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
4. hlyr/src/commands/claude/init.ts:414
- Draft comment:
Updating .gitignore for hack scripts via ensureGitignoreEntry is a good move to prevent accidental commits of these scripts. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
5. hlyr/src/commands/claude/init.ts:348
- Draft comment:
Consider handling duplicate section comments in .gitignore if this command is run multiple times. It may add multiple '# Claude Code local settings' blocks. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_Mql9afreqN9I60EX
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #902
The
humanlayer claude initcommand now copies the required hack scripts that are referenced by.claude/commands, preventing "file not found" errors when users run commands.Changes
Added 'scripts' category to claude init
--allflagScript copying logic
hack/spec_metadata.shandhack/create_worktree.shto target repo'shack/directorychmod 0o755hack/directory if it doesn't exist.gitignore handling
Improved output
.claudeandhackdirectories when scripts are copiedTesting
Tested with:
Results:
Important
claudeInitCommandnow copies required hack scripts, makes them executable, and updates.gitignoreto prevent commit errors.claudeInitCommandininit.tsnow copiesspec_metadata.shandcreate_worktree.shto the target repo'shack/directory.chmod 0o755..gitignoreto prevent them from being committed.--allflag..gitignoreentries.This description was created by
for a60bbb7. You can customize this summary. It will automatically update as commits are pushed.