Repository navigation
Update React guide for v3 - #1128
Merged
Merged
Conversation
3 of 4 tasks
xenova
reviewed
Jan 1, 2025
xenova
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for this! I missed this when updating the docs for the Transformers.js v3 release. One thing which would probably be better is for the callback function to only post back the new text (and then the new text should be appended to the existing text, on the react side of things).
Contributor
Author
|
True, particularly for an example. Old habit of production code where fixing bugs with the smallest number of changes. |
xenova
approved these changes
Jan 15, 2025
Collaborator
|
Thanks again @sroussey! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revise the React guide to incorporate changes related to the new streaming capabilities.