chore(ci): remove dead env vars from circleci-failure-summary-comment.yml#45972
Open
XciD wants to merge 2 commits into
Open
chore(ci): remove dead env vars from circleci-failure-summary-comment.yml#45972XciD wants to merge 2 commits into
XciD wants to merge 2 commits into
Conversation
….yml
`TARGET_BRANCH` and `TARGET_SHA` were declared at the job level but never
referenced by any subsequent step. `PR_NUMBER` was also declared at the
job level but every step that needs it re-declares its own step-local
`PR_NUMBER: ${{ github.event.pull_request.number }}` env, so the
job-level binding was equally unused.
Drop the entire job-level `env:` block. No behavior change.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/circleci-failure-summary-comment.ymldeclared three env vars at thecommentjob level:None of them are referenced:
TARGET_BRANCHandTARGET_SHAare never used by any step in the job.PR_NUMBERis re-declared as a step-local env in every step that needs it (lines 164, 198, 234), so the job-level binding does nothing.Drop the whole
env:block. No behavior change.Closes #45968 (the hf-security-analysis bot proposed to rename these vars; the right fix is to delete them).