Less unnecessary RoPE warnings#45289
Merged
zucchini-nlp merged 6 commits intohuggingface:mainfrom Apr 13, 2026
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
vasqu
approved these changes
Apr 10, 2026
Contributor
vasqu
left a comment
There was a problem hiding this comment.
In general happy to have it, I remember some models, e.g. deepseek v3, recasting to float before; exactly because of this. Would be nice if you could cross check
Contributor
|
#45404 will fix the CI |
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: deepseek_v3, longcat_flash, mistral4, youtu |
sirzechs66
pushed a commit
to sirzechs66/transformers
that referenced
this pull request
Apr 18, 2026
* suppress warning if int * remove override, not needed anymore * also youtu --------- Co-authored-by: Anton Vlasjuk <73884904+vasqu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #45265 and doesn't warn if the value is an int.