[docs] refactoring docstrings in models/embeddings_flax.py#9592
Merged
Conversation
a-r-r-o-w
reviewed
Oct 5, 2024
a-r-r-o-w
left a comment
Contributor
There was a problem hiding this comment.
Thanks, looks good! Could you look into the failing tests? I think you just have to run make style to fix
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Jwaminju
commented
Oct 8, 2024
a6b1cb5 to
0b56883
Compare
Contributor
Author
|
Thanks for the review! I have removed trailing whitespace! |
sayakpaul
pushed a commit
that referenced
this pull request
Dec 23, 2024
* [docs] refactoring docstrings in `models/embeddings_flax.py` * Update src/diffusers/models/embeddings_flax.py * make style --------- Co-authored-by: Aryan <aryan@huggingface.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes part of #9567
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
This PR tries to attempt a solution at one of the submodules listed in #9567 so I think @a-r-r-o-w is the best to review it. Alongside the same, @charchit7 @yijun-lee and @SubhasmitaSw were also working on the same, so just a ping for the update on the same.