[ldm3d] Ldm3d upscaler to community pipeline by estelleafl · Pull Request #5870 · huggingface/diffusers

estelleafl · 2023-11-20T16:56:51Z

Hi @patrickvonplaten,
Finally, I created a new PR for our contribution to the community pipelines. We can close the previous one (#5660)
Thank you for your help
Best

…ldm3d_rgbd_4channels

…ldm3d_rgbd_4channels tests/pipelines/stable_diffusion/test_stable_diffusion_ldm3d.py

…ldm3d_rgbd_4channels

…ldm3d_docs_fix

HuggingFaceDocBuilderDev · 2023-11-20T17:03:34Z

The documentation is not available anymore as the PR was closed or merged.

estelleafl · 2023-11-21T07:38:26Z

I am getting the error below when running make style/make quality.
I tried also from main and not on my branch and Im getting this error as well. Would you know why?

ruff check examples scripts src tests utils setup.py --fix
error: TOML parse error at line 16, column 1
|
16 | [tool.ruff.format]
| ^^^^^^^^^^^^^^^^^^
wanted exactly 1 element, more than 1 element

make: *** [Makefile:56: style] Error 2

…ldm3d_upscaler_community

patrickvonplaten · 2023-11-21T17:01:56Z

        else:
            raise Exception(f"This type {output_type} is not supported")
+
+    def preprocess(


Hmm is this really needed?

the preprocess? or the raise?

Ah sorry I misread here, actually this look ok to me - @yiyixuxu wdyt?

yeah fine with me too!

Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>

…afl/diffusers into ldm3d_upscaler_community

patrickvonplaten

The changes look good to me - @yiyixuxu wdyt?

patrickvonplaten · 2023-11-27T11:37:06Z

        else:
            raise Exception(f"This type {output_type} is not supported")
+
+    def preprocess(


Ah sorry I misread here, actually this look ok to me - @yiyixuxu wdyt?

yiyixuxu · 2023-11-27T21:09:08Z

I am getting the error below when running make style/make quality. I tried also from main and not on my branch and Im getting this error as well. Would you know why?

ruff check examples scripts src tests utils setup.py --fix error: TOML parse error at line 16, column 1 | 16 | [tool.ruff.format] | ^^^^^^^^^^^^^^^^^^ wanted exactly 1 element, more than 1 element

make: *** [Makefile:56: style] Error 2

can you try upgrading ruff?

pip install --upgrade ruff

…ldm3d_upscaler_community

…afl/diffusers into ldm3d_upscaler_community

estelleafl · 2023-11-28T09:20:58Z

Thank you @patrickvonplaten and @yiyixuxu
I made style/quality following @yiyixuxu advice

yiyixuxu · 2023-11-28T19:01:04Z

@estelleafl
merged! thank you :)

--------- Co-authored-by: Aflalo <estellea@isl-gpu27.rr.intel.com> Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com> Co-authored-by: YiYi Xu <yixu310@gmail.com>

Aflalo and others added 30 commits June 18, 2023 04:52

fixed typo

471e5c1

updated doc to be consistent in naming

7f5edc5

make style/quality

5dddd0e

preprocessing for 4 channels and not 6

ec18756

make style

b6f1a7f

Merge branch 'main' of https://github.com/huggingface/diffusers into …

dc12b27

…ldm3d_rgbd_4channels

test for 4c

d7348d6

make style/quality

ef923aa

Merge branch 'main' of https://github.com/huggingface/diffusers into …

7d58eb0

…ldm3d_rgbd_4channels tests/pipelines/stable_diffusion/test_stable_diffusion_ldm3d.py

fixed test on cpu

3b242c3

Merge branch 'main' of https://github.com/huggingface/diffusers into …

e21f8e3

…ldm3d_rgbd_4channels

fixed doc typo

a7249bf

changed default ckpt to 4c

1e5cabb

Update pipeline_stable_diffusion_ldm3d.py

5d0b7e6

Merge branch 'main' of https://github.com/huggingface/diffusers into …

2da08c6

…ldm3d_docs_fix

convert file

9d8bd99

Merge remote-tracking branch 'upstream/main' into convert_ckpt_file

a82d42f

ldm3d upscaler first commit

5ce1e7e

temp commit

1a3b3fd

ckpt conversion fix

1eab17d

upscaler from ldm3d

4aa1440

added ldm3d-hr

6ab7729

merge to upstream

40ef851

convert ckpts

442d604

doc ldm3d upscaler

65fc7f2

updated hr to sr

ef2d1e0

make style

a24bd3c

make style

00f0524

variable not defined bug

0546099

make style

717654b

Aflalo added 3 commits November 20, 2023 08:51

merge

3080a9e

update doc

3423807

fixed

8141647

estelleafl changed the title ~~Ldm3d upscaler community~~ [ldm3d] Ldm3d upscaler to community pipeline Nov 20, 2023

estelleafl mentioned this pull request Nov 20, 2023

[ldm3d] Ldm3d-sr - upscaler #5660

Closed

Aflalo added 2 commits November 20, 2023 23:56

Merge branch 'main' of https://github.com/huggingface/diffusers into …

66097e3

…ldm3d_upscaler_community

revert change

35c0e16

patrickvonplaten reviewed Nov 21, 2023

View reviewed changes

Comment thread src/diffusers/image_processor.py Outdated

patrickvonplaten reviewed Nov 21, 2023

View reviewed changes

Comment thread src/diffusers/image_processor.py Outdated

patrickvonplaten reviewed Nov 21, 2023

View reviewed changes

Comment thread src/diffusers/image_processor.py Outdated

patrickvonplaten requested a review from yiyixuxu November 21, 2023 17:02

estelleafl and others added 5 commits November 22, 2023 08:59

Update src/diffusers/image_processor.py

55079df

Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>

Update src/diffusers/image_processor.py

1a11b35

Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>

numpy to pil depth >to depth:

58aafad

Merge branch 'ldm3d_upscaler_community' of https://github.com/estelle…

1b9a5f3

…afl/diffusers into ldm3d_upscaler_community

merge to upstream

7d874cf

patrickvonplaten approved these changes Nov 27, 2023

View reviewed changes

yiyixuxu and others added 4 commits November 27, 2023 11:09

Merge branch 'main' into ldm3d_upscaler_community

bd4047b

make style/quality

b47311c

Merge branch 'main' of https://github.com/huggingface/diffusers into …

dd2ba34

…ldm3d_upscaler_community

Merge branch 'ldm3d_upscaler_community' of https://github.com/estelle…

6d78bd1

…afl/diffusers into ldm3d_upscaler_community

yiyixuxu merged commit 5ae3c3a into huggingface:main Nov 28, 2023

Uh oh!

Conversation

estelleafl commented Nov 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HuggingFaceDocBuilderDev commented Nov 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

estelleafl commented Nov 21, 2023

Uh oh!

Uh oh!

Uh oh!

patrickvonplaten Nov 21, 2023

Choose a reason for hiding this comment

Uh oh!

estelleafl Nov 22, 2023

Choose a reason for hiding this comment

Uh oh!

patrickvonplaten Nov 27, 2023

Choose a reason for hiding this comment

Uh oh!

yiyixuxu Nov 27, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

patrickvonplaten left a comment

Choose a reason for hiding this comment

Uh oh!

patrickvonplaten Nov 27, 2023

Choose a reason for hiding this comment

Uh oh!

yiyixuxu commented Nov 27, 2023

Uh oh!

estelleafl commented Nov 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yiyixuxu commented Nov 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

estelleafl commented Nov 20, 2023 •

edited

Loading

HuggingFaceDocBuilderDev commented Nov 20, 2023 •

edited

Loading

estelleafl commented Nov 28, 2023 •

edited

Loading