[Utils] Correct custom init sort#4967
Merged
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
Contributor
Author
|
@DN6 feel free to take over this PR |
Collaborator
|
@patrickvonplaten Ready for review. |
Contributor
Author
|
Nice! Merging to avoid merge conflicts |
dg845
added a commit
to dg845/diffusers
that referenced
this pull request
Sep 18, 2023
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
* [Utils] Correct custom init sort * [Utils] Correct custom init sort * [Utils] Correct custom init sort * add type checking * fix custom init sort * fix test * fix tests --------- Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
* [Utils] Correct custom init sort * [Utils] Correct custom init sort * [Utils] Correct custom init sort * add type checking * fix custom init sort * fix test * fix tests --------- Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently
make styleis broken. We need to fix this by addingif TYPE_CHECKINGto all pipeline init classes (see: https://github.com/huggingface/diffusers/pull/4829/files#r1321159892)@DN6 can you do a follow-up PR here? Given the amount of file, I would try to write a script that does that automatically for you.
As a way of testing the PR we should make sure that
make styledoesn't error out.