Allow directly passing text embeddings to Stable Diffusion Pipeline for prompt weighting#2071
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
pcuenca
reviewed
Jan 24, 2023
pcuenca
left a comment
Member
There was a problem hiding this comment.
I reviewed the first pipeline in depth, the comments would apply to others. I believe there's a typo in the InstructPix2PixPipeline?
patil-suraj
reviewed
Jan 24, 2023
patil-suraj
left a comment
Contributor
There was a problem hiding this comment.
Looks good. I just left some nits. And as Pedro said, for InstrcutPix2Pix, we need uncond embedding concat is different from other pipelines.
pcuenca
approved these changes
Jan 24, 2023
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
…or prompt weighting (huggingface#2071) * add text embeds to sd * add text embeds to sd * finish tests * finish * finish * make style * fix tests * make style * make style * up * better docs * fix * fix * new try * up * up * finish
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
…or prompt weighting (huggingface#2071) * add text embeds to sd * add text embeds to sd * finish tests * finish * finish * make style * fix tests * make style * make style * up * better docs * fix * fix * new try * up * up * finish
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows to pass text_embeddings directly to the SD pipelines which should greatly help with writing pipelines such as Weight Prompting, Prompt-2-Prompt, etc...
For more details see discussion here: #1506 (comment)
As it's always the same function (
self._encode_prompt), two tests for stable diffusion should be enough here IMO.