align snapshot_download to respect hfh latest version#14118
Draft
sayakpaul wants to merge 3 commits into
Draft
Conversation
Member
|
The PEFT tests succeed on this branch, thanks a lot. (reminder to myself: testing with |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
BenjaminBossan
approved these changes
Jul 3, 2026
BenjaminBossan
left a comment
Member
There was a problem hiding this comment.
I can't comment on the logic of the fix, but it resolves the PEFT errors. Thanks.
| lambda image_url_or_path: load_image(image_url_or_path) | ||
| if urlparse(image_url_or_path).scheme | ||
| else Image.open(image_url_or_path).convert("RGB") | ||
| lambda image_url_or_path: ( |
Member
There was a problem hiding this comment.
Changes seem to be unrelated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #14117
@BenjaminBossan does this work for you?