fix Mellon custom block required input handling#13888
Open
wunianze666-netizen wants to merge 1 commit into
Open
fix Mellon custom block required input handling#13888wunianze666-netizen wants to merge 1 commit into
wunianze666-netizen wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR preserves required custom block inputs when generating a Mellon config.
Motivation
While reviewing the Mellon custom block flow, I noticed that MellonPipelineConfig.from_custom_block() always emitted an empty
equired_inputs list, even when a block input was declared with
equired=True. The same code path also printed a debug line for every input.
This makes the generated Mellon schema less accurate for custom blocks and can leak noisy stdout from a library API. This came up while reading through the modular Mellon findings in #13650.
Changes
equired_inputs metadata
Testing
Notes
I could not run the pytest target in this local environment because pytest and the repo's development dependencies are not installed here, so I limited verification to a syntax check and a focused regression test addition.