PNDM API Updates, Tests Cleaning#103
Merged
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
| image = image.to(torch_device) | ||
|
|
||
| prk_time_steps = self.scheduler.get_prk_time_steps(num_inference_steps) | ||
| prk_time_steps = self.scheduler.get_timesteps(num_inference_steps, step_mode="prk") |
Contributor
There was a problem hiding this comment.
Ideally I'd like to not have a get_... function at all, but just self.prk_timesteps and self.plms_timesteps - what do you think?
|
|
||
| prk_time_steps = self.scheduler.get_prk_time_steps(num_inference_steps) | ||
| prk_time_steps = self.scheduler.get_timesteps(num_inference_steps, step_mode="prk") | ||
| for t in tqdm(range(len(prk_time_steps))): |
Contributor
There was a problem hiding this comment.
this should be:
for t in tqdm(self.prk_timesteps):
...
IMO
and it'd be nice if we would only have:
scheduler.set_timesteps(...)
which sets up both self.prk_timesteps and self.plms_timesteps arrays
Contributor
Author
There was a problem hiding this comment.
Yeah I like this, going to make these changes now.
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
* organize PNDM tests, begin API change * clean timestep API PNDM * update pipeline PNDM * fix typo * API clean round 2 * small nit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Major changes:
plmstestsget_timestepsandset_timestepsfunctions to match API with other schedulers (no longer one per timestep type)