search - Remove unused change event cases

roblourens · roblourens · commit 5983f1e14ad0 · 2019-08-31T15:01:07.000-07:00
diff --git a/src/vs/workbench/contrib/search/browser/searchView.ts b/src/vs/workbench/contrib/search/browser/searchView.ts
@@ -446,21 +446,13 @@ export class SearchView extends ViewletPanel {
 	refreshTree(event?: IChangeEvent): void {
 		const collapseResults = this.configurationService.getValue<ISearchConfigurationProperties>('search').collapseResults;
 		if (!event || event.added || event.removed) {
+			// Refresh whole tree
 			this.tree.setChildren(null, this.createResultIterator(collapseResults));
 		} else {
+			// FileMatch modified, refresh those elements
 			event.elements.forEach(element => {
-				if (element instanceof BaseFolderMatch) {
-					// The folder may or may not be in the tree. Refresh the whole thing.
-					this.tree.setChildren(null, this.createResultIterator(collapseResults));
-					return;
-				}
-
-				if (element instanceof SearchResult) {
-					this.tree.setChildren(null, this.createIterator(element, collapseResults));
-				} else {
-					this.tree.setChildren(element, this.createIterator(element, collapseResults));
-					this.tree.rerender(element);
-				}
+				this.tree.setChildren(element, this.createIterator(element, collapseResults));
+				this.tree.rerender(element);
 			});
 		}
 	}
diff --git a/src/vs/workbench/contrib/search/common/searchModel.ts b/src/vs/workbench/contrib/search/common/searchModel.ts
@@ -400,7 +400,7 @@ export class FileMatch extends Disposable implements IFileMatch {
 }
 
 export interface IChangeEvent {
-	elements: (FileMatch | FolderMatch | SearchResult)[];
+	elements: FileMatch[];
 	added?: boolean;
 	removed?: boolean;
 }

Original file line number	Diff line number	Diff line change
`@@ -400,7 +400,7 @@ export class FileMatch extends Disposable implements IFileMatch {`
`400`	`400`	`}`
`401`	`401`
`402`	`402`	`export interface IChangeEvent {`
`403`		`- elements: (FileMatch \| FolderMatch \| SearchResult)[];`
	`403`	`+ elements: FileMatch[];`
`404`	`404`	`added?: boolean;`
`405`	`405`	`removed?: boolean;`
`406`	`406`	`}`