Fix microsoft#80134 - editor service requires strongly typed options

roblourens · roblourens · commit d195206606e2 · 2019-08-31T13:34:46.000-07:00
diff --git a/src/vs/workbench/services/preferences/browser/preferencesService.ts b/src/vs/workbench/services/preferences/browser/preferencesService.ts
@@ -214,7 +214,7 @@ export class PreferencesService extends Disposable implements IPreferencesServic
 
 	private openSettings2(options?: ISettingsEditorOptions): Promise<IEditor> {
 		const input = this.settingsEditor2Input;
-		return this.editorService.openEditor(input, options)
+		return this.editorService.openEditor(input, options ? SettingsEditorOptions.create(options) : undefined)
 			.then(() => this.editorGroupService.activeGroup.activeControl!);
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -214,7 +214,7 @@ export class PreferencesService extends Disposable implements IPreferencesServic`
`214`	`214`
`215`	`215`	`private openSettings2(options?: ISettingsEditorOptions): Promise<IEditor> {`
`216`	`216`	`const input = this.settingsEditor2Input;`
`217`		`- return this.editorService.openEditor(input, options)`
	`217`	`+ return this.editorService.openEditor(input, options ? SettingsEditorOptions.create(options) : undefined)`
`218`	`218`	`.then(() => this.editorGroupService.activeGroup.activeControl!);`
`219`	`219`	`}`
`220`	`220`