Reading the actual request may trigger CONNRESET on a cached connection#62
Open
smurfix wants to merge 2 commits intohttplib2:masterfrom
Open
Reading the actual request may trigger CONNRESET on a cached connection#62smurfix wants to merge 2 commits intohttplib2:masterfrom
smurfix wants to merge 2 commits intohttplib2:masterfrom
Conversation
(if the connection was cached) thus move that code inside the try:.
Handle ECONNRESET and EPIPE correctly and simplify the code a bit (pull up conn.close() while we're at it
Member
|
Thank you very much. Patch seems fine. Dear users and @httplib2/maintainers is it possible to give this one a bit of field testing? To compensate automated tests.
|
2a3a5f5 to
70fb0c8
Compare
|
Suggest adding the connection retry for errno.ECONNABORTED. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the block that reads the data up into the try: block.
I hit this issue while testing aioamqp with pyrabbit. The sequence of events is:
(like doing a DNS lookup for its error log)
This can also happen when you're re-using a cached connection after some time and hit the server's decision that it has waited long enough and will now close the connection.
Thus, please apply.
(This is a copy/rebase of jcgregorio/httplib2#320)