Skip to content

Release as a universal wheel#29

Open
adamchainz wants to merge 1 commit intohttplib2:masterfrom
adamchainz:universal_wheels
Open

Release as a universal wheel#29
adamchainz wants to merge 1 commit intohttplib2:masterfrom
adamchainz:universal_wheels

Conversation

@adamchainz
Copy link
Copy Markdown

@adamchainz adamchainz commented Oct 13, 2016

By releasing as a Python wheel as well as a source distribution, you can speed up end user’s installs. After merging this command, to release you just need to run python setup.py clean sdist bdist_wheel upload.

Release as a universal wheel
78b2615 
By releasing as a [Python wheel](http://pythonwheels.com/) as well as a source distribution, you can speed up end user’s installs. After merging this command, to release you just need to run `python setup.py clean sdist bdist_wheel upload`.
@temoto
Copy link
Copy Markdown
Member

temoto commented Mar 28, 2018

Blocked by #96

@temoto temoto force-pushed the master branch 7 times, most recently from 2a3a5f5 to 70fb0c8 Compare March 30, 2018 02:22
@Globegitter Globegitter mentioned this pull request Jul 17, 2018
Closed
@fengxx
Copy link
Copy Markdown

fengxx commented Mar 4, 2019

could we release two wheel packages before #96 get fixed?
run pythonX setup.py clean bdist_wheel will generate wheels
httplib2-0.12.1-py2-none-any.whl httplib2-0.12.1-py3-none-any.whl

@temoto
Copy link
Copy Markdown
Member

temoto commented Mar 4, 2019

@fengxx sure, please check it. I uploaded 0.12.1 to test PyPI, wheels only.

pip install -i https://test.pypi.org/simple/ httplib2

@nsoranzo nsoranzo mentioned this pull request Mar 25, 2019
Open
52 tasks
@fengxx
Copy link
Copy Markdown

fengxx commented Apr 11, 2019

sorry for late response, py3 package is ok, but the py2 package seems not be packaged correctly

from httplib2 import socks
lib/python2.7/site-packages/httplib2/__init__.py", line 462
    print("%s:" % h, end=" ", file=self._fp)

Files used for testing

python2.7 -m pip download --no-deps -i https://test.pypi.org/simple/ httplib2
Looking in indexes: https://test.pypi.org/simple/
Collecting httplib2
  Downloading https://test-files.pythonhosted.org/packages/40/11/ff7332ee8d2a6fa29d61bb5ea09c23a14dcaa4429aa17e1588c0c65d5c8a/httplib2-0.12.1-py2-none-any.whl (95kB)
    100% |████████████████████████████████| 102kB 810kB/s
  Saved ./httplib2-0.12.1-py2-none-any.whl
Successfully downloaded httplib2

python3 -m pip download --no-deps -i https://test.pypi.org/simple/ httplib2

  Downloading https://test-files.pythonhosted.org/packages/6c/a6/55095dd1be5d1326b191ed1e73080a5ac4ebe59c335ededfa4c9f0cc1b47/httplib2-0.12.1-py3-none-any.whl (94kB)
    100% |████████████████████████████████| 184kB 1.3MB/s
  Saved ./httplib2-0.12.1-py3-none-any.whl
Successfully downloaded httplib2

@fengxx
Copy link
Copy Markdown

fengxx commented Apr 11, 2019

I think we need use clean --all to remove build/lib folder

running clean
removing 'build/lib' (and everything under it)
removing 'build/bdist.macosx-10.12-x86_64' (and everything under it)
'build/scripts-2.7' does not exist -- can't clean it
running bdist_wheel
running build
running build_py
creating build/lib
creating build/lib/httplib2
copying python2/httplib2/iri2uri.py -> build/lib/httplib2
copying python2/httplib2/certs.py -> build/lib/httplib2
copying python2/httplib2/__init__.py -> build/lib/httplib2
copying python2/httplib2/socks.py -> build/lib/httplib2
copying python2/httplib2/cacerts.txt -> build/lib/httplib2
...

Otherwise build/lib is not cleaned up, which may contain python3 code

@temoto
Copy link
Copy Markdown
Member

temoto commented Apr 12, 2019

@fengxx Thanks, I re-uploaded it after clean --all as 0.12.2. That import ...socks line passed. Please check more.

temoto added a commit that referenced this pull request Apr 12, 2019
@temoto
release: clean --all helps to make wheels #29
51bcdd2
@temoto temoto mentioned this pull request Apr 12, 2019
Merged
@fengxx
Copy link
Copy Markdown

fengxx commented Apr 22, 2019

thanks, 0.12.2 works on both py2/py3

clrpackages pushed a commit to clearlinux-pkgs/httplib2 that referenced this pull request May 6, 2019
@fenrus75 @djklimes
[update to 0.12.3] Fix a warning under Python 3.7
64ac7fb 
Felix Yan (1):
      Fix a warning under Python 3.7

Sergey Shepelev (5):
      v0.12.1 release
      release: clean --all helps to make wheels httplib2/httplib2#29
      travis: upgrade service jobs python 3.6 -> 3.7 for no good reason; fix indent in script/release
      release non-universal wheels
      v0.12.3 release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adamchainz @temoto @fengxx