Skip to content

Fix appveryor pipelines#596

Open
loqs wants to merge 2 commits intohtml5lib:masterfrom
loqs:fix-appveryor-pipelines
Open

Fix appveryor pipelines#596
loqs wants to merge 2 commits intohtml5lib:masterfrom
loqs:fix-appveryor-pipelines

Conversation

@loqs
Copy link
Copy Markdown

@loqs loqs commented Apr 13, 2026 •
edited
Loading

  • Change appveryor's image to Visual Studio 2017 from Visual Studio 2022. Visual Studio 2017 is the most recent Visual Studio image still containing python 3.7.
    • Alternatives:
      • Install python 3.7 on Visual Studio 2022.
      • Switch to a Ubuntu based image.
  • Add upper bound < 5.0.0 to lxml for python 2.7 in requirements-optional.txt.
    • Alternatives:
      • Use an upper bound of < 5.1.0 for Linux and 5.1.0 for Windows.
      • Use an upper bound of 5.1.0 and attempt to build lxml from source.
      • Switch to a Ubuntu based image.

loqs added 2 commits April 12, 2026 23:47
@loqs
appveyor: Change image to Visual Studio 2017
c995e01 
appveyor's Visual Studio 2022 images update on September 4, 2024
removed support for python 3.7 as documented in https://www.appveyor.com/updates/2024/06/13/.
@loqs
Add upper bound < 5.0.0 to lxml for python 2.7
ef6d073 
Support for python 2.7 was removed inhttps://pypi.org/project/lxml/5.1.0/.
However there are no python 2.7 wheels for Windows for lxml >- 5.0.0.
@loqs
Copy link
Copy Markdown
Author

loqs commented Apr 13, 2026

@cclauss as the last person to touch .appveyor.yml.

@cclauss
Copy link
Copy Markdown
Contributor

cclauss commented Apr 13, 2026

I am not a maintainer, so I cannot approve the workflows, etc.

@loqs
Copy link
Copy Markdown
Author

loqs commented Apr 13, 2026

@cclauss I apologize for not being clear. Were all appveryor pipelines passing for 4a87368? I tried checking the relevant logs however they are no longer available. Do my suggested changes seem reasonable to you? I am not familiar with appveyor.

cclauss
cclauss reviewed Apr 13, 2026
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cclauss cclauss cclauss left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@loqs @cclauss