Make ReparseException private#373
Merged
willkg merged 1 commit intohtml5lib:masterfrom Nov 29, 2017
willkg:371-reparse-private
Merged
Make ReparseException private#373willkg merged 1 commit intohtml5lib:masterfrom willkg:371-reparse-private
willkg merged 1 commit intohtml5lib:masterfrom
willkg:371-reparse-private
Conversation
ReparseException is used internally and not intended for external use. Fixes #371
Contributor
Author
|
@gsnedders or @jgraham : can one of you review this, please? |
gsnedders
approved these changes
Nov 29, 2017
Codecov Report
@@ Coverage Diff @@
## master #373 +/- ##
=======================================
Coverage 90.78% 90.78%
=======================================
Files 50 50
Lines 6927 6927
Branches 1322 1322
=======================================
Hits 6289 6289
Misses 482 482
Partials 156 156
Continue to review full report at Codecov.
|
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReparseException is used internally and not intended for external use.
Fixes #371