Use empty envelope address where possible - #514
Merged
Conversation
Contributor
Collaborator
Author
It's easier to add comments under "Files changed" instead. I have:
|
martinknafve
referenced
this pull request
Apr 18, 2026
martinknafve
force-pushed
the
feature/use-empty-envelope-frm
branch
from
April 19, 2026 13:14
c56eef5 to
f8db462
Compare
RvdHout
added a commit
to RvdHout/hmailserver
that referenced
this pull request
Apr 20, 2026
DKIM-sign all email sent from domain (hmailserver#512) * Sign all emails from local domains. * Prevent duplicate DKIM signatures * Use From header instead of envelope from * Removed redundant validation of used algorithm ---------------------- Fix: Emails stored without trailing newline (hmailserver#513) The fix for hmailserver#500 introduced an issue where email messages were sometimes missing a trailing newline on disk. This later lead to issues parsing the content. The code has been updated so that the trailing newline is added, and the parsing has been made more robust. ---------------------- Fix: Garbage after closing boundary could lead to truncated data If an malformed email was processed, data after the malformed portion could be truncated. ---------------------- Use empty envelope address where possible (hmailserver#514)
cybercode3
added a commit
to cybercode3/hmailserver
that referenced
this pull request
Apr 21, 2026
- Fix: IMAP FETCH does not properly honour "<start.size>" clause hmailserver#334 (hmailserver/hmailserver@009e870) - Fix: Invalid Recent-count in IMAP notifications (hmailserver/hmailserver@2c860c9) - Removed unnecessary message load (hmailserver/hmailserver@81ecc7f) - Fold long lines when using QP-encoding, hmailserver#171 (hmailserver#515) (hmailserver/hmailserver@5a5015b) - Use empty envelope address where possible (hmailserver#514) (hmailserver/hmailserver@5e46b81) - Fix: Long ZIP filenames and foreign " ö "cause 'block attachment' renaming and conversion errors hmailserver#145 (hmailserver#516) (hmailserver/hmailserver@b73d8fa)
martinknafve
pushed a commit
that referenced
this pull request
May 9, 2026
…523) - Fix some spam scoring inconsistencies, for example the spam-counter was not updated in POP3ClientConnection when a message scored above the SpamDeleteThreshold - Make sure both the SpamMarkThreshold and SpamDeleteThreshold are > 0 - If SpamMarkThreshold and SpamDeleteThreshold are set to 0, disable this functionality Add a internal (persistent) FlagSpam message flag as these below are optional and can be disabled - Add X-hMailServer-Spam - Add X-hMailServer-Reason - Add to message subject Use the internal FlagSpam message flag to (optionally) determine if a message should be forwarded, replied to if defined by either Rule or with a Account Forward/OOF when a message is considered/marked as being spam webadmin and tests included ----------------------------------- In RuleApplier.cpp the include MailerDaemonAddressDeterminer.h can be removed, there was also a orphaned std::shared_ptr<Account> emptyAccount; that wasn't used In SMTPVacationMessageCreator.cpp the SetReturnPath action can also be removed, as part of #514
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.