Skip to content

test: add test for mkdir running in read-only filesystem#1

Merged
hiimjako merged 1 commit intohiimjako:fix/mkdirp-EROFSfrom
kwaszczuk:fix/mkdirp-EROFS
Feb 28, 2025
Merged

test: add test for mkdir running in read-only filesystem#1
hiimjako merged 1 commit intohiimjako:fix/mkdirp-EROFSfrom
kwaszczuk:fix/mkdirp-EROFS

Conversation

@kwaszczuk
Copy link
Copy Markdown

@kwaszczuk kwaszczuk commented Feb 28, 2025 •
edited
Loading

Added test case for nodejs/pull/48105

Tested locally (both with and without root permission):

$ tools/test.py test/parallel/test-fs-mkdir.js
[00:00|% 100|+   1|-   0]: Done

All tests passed.

$ sudo tools/test.py test/parallel/test-fs-mkdir.js
[00:00|% 100|+   1|-   0]: Done

All tests passed.

@kwaszczuk kwaszczuk changed the title test: add test for mkdir running in RO filesystem test: add test for mkdir running in read-only filesystem Feb 28, 2025
@kwaszczuk
Copy link
Copy Markdown
Author

kwaszczuk commented Feb 28, 2025

@hiimjako Once this one gets merged, the PR in the original NodeJS repository should be unblocked.

@hiimjako
Copy link
Copy Markdown
Owner

hiimjako commented Feb 28, 2025

Hey!
Amazing work 😄
Thanks!

@hiimjako hiimjako merged commit db9e65a into hiimjako:fix/mkdirp-EROFS Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kwaszczuk @hiimjako